Skip to content

[787] Add maven wrapper for consistent builds#788

Merged
the-other-tim-brown merged 4 commits into
apache:mainfrom
the-other-tim-brown:787-add-maven-wrapper
Jan 16, 2026
Merged

[787] Add maven wrapper for consistent builds#788
the-other-tim-brown merged 4 commits into
apache:mainfrom
the-other-tim-brown:787-add-maven-wrapper

Conversation

@the-other-tim-brown
Copy link
Copy Markdown
Contributor

@the-other-tim-brown the-other-tim-brown commented Jan 16, 2026 •
edited
Loading

What is the purpose of the pull request

Closes #787

  • Adds a maven wrapper for consistent builds. This also allows users to build the project without installing maven themselves

Brief change log

  • Maven wrapper is generated with version 3.9.11
  • Docs are updated to reference the wrapper for consistency between environments and make the setup process easier

Verify this pull request

  • If CI passes, we know the change is having the intended effect

vinishjail97
vinishjail97 reviewed Jan 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vinishjail97 vinishjail97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/incubator-xtable/blob/main/Dockerfile#L25
https://github.com/search?q=repo%3Aapache%2Fincubator-xtable%20mvn&type=code
There are few files that have been missed...do we want to follow the same style across the repo or left out for any reason?

@the-other-tim-brown
Copy link
Copy Markdown
Contributor Author

the-other-tim-brown commented Jan 16, 2026

https://github.com/apache/incubator-xtable/blob/main/Dockerfile#L25 https://github.com/search?q=repo%3Aapache%2Fincubator-xtable%20mvn&type=code There are few files that have been missed...do we want to follow the same style across the repo or left out for any reason?

@vinishjail97 there is one place I am unsure about: deploy_staging_jars - Can you suggest how to update the $MVN part?

@vinishjail97
Copy link
Copy Markdown
Contributor

vinishjail97 commented Jan 16, 2026

https://github.com/apache/incubator-xtable/blob/main/Dockerfile#L25 https://github.com/search?q=repo%3Aapache%2Fincubator-xtable%20mvn&type=code There are few files that have been missed...do we want to follow the same style across the repo or left out for any reason?

@vinishjail97 there is one place I am unsure about: deploy_staging_jars - Can you suggest how to update the $MVN part?

We can use MVN=${MVN:-./mvnw} in the beginning of the script verified it works locally.

@the-other-tim-brown the-other-tim-brown marked this pull request as ready for review January 16, 2026 20:02
@the-other-tim-brown the-other-tim-brown merged commit 50ae611 into apache:main Jan 16, 2026
3 checks passed
@the-other-tim-brown the-other-tim-brown deleted the 787-add-maven-wrapper branch January 16, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinishjail97 vinishjail97 vinishjail97 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI Failures when building xtable-service module

2 participants

@the-other-tim-brown @vinishjail97